Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add validation for OsFamily annotation value #289

Merged

Conversation

eytan-avisror
Copy link
Collaborator

Signed-off-by: Eytan Avisror eytan_avisror@intuit.com

Fixes: #288

Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
@eytan-avisror eytan-avisror requested review from a team as code owners May 3, 2021 23:09
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #289 (a0a5685) into master (503d90c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
+ Coverage   70.00%   70.02%   +0.01%     
==========================================
  Files          19       19              
  Lines        3094     3096       +2     
==========================================
+ Hits         2166     2168       +2     
  Misses        788      788              
  Partials      140      140              
Impacted Files Coverage Δ
controllers/provisioners/eks/eks.go 89.13% <100.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 503d90c...a0a5685. Read the comment docs.

Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Copy link
Contributor

@vgunapati vgunapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eytan-avisror eytan-avisror merged commit dcabfb3 into keikoproj:master May 3, 2021
@eytan-avisror eytan-avisror mentioned this pull request May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OsFamily missing validation in case wrong family provided
2 participants