fix: Ignore mixedInstancePolicy if type is LaunchConfig #303
Conversation
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
eytan-avisror
changed the title
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
==========================================
- Coverage 70.11% 70.06% -0.05%
==========================================
Files 19 19
Lines 3105 3107 +2
==========================================
Hits 2177 2177
- Misses 788 789 +1
- Partials 140 141 +1
Continue to review full report at Codecov.
|
api/v1alpha1/instancegroup_types.go
Outdated
| @@ -392,6 +392,13 @@ func (s *EKSSpec) Validate() error { | |||
| s.Type = LaunchConfiguration | |||
| } | |||
|
|
|||
| if s.Type == LaunchConfiguration { | |||
| if s.EKSConfiguration.MixedInstancesPolicy != nil { | |||
| log.Info("cannot use mixedInstancesPolicy with LaunchConfiguration, will ignore provided mixedInstancePolicy") | |||
There was a problem hiding this comment.
Not sure if this log is going to be very useful - does it contain any identifying information for the IG?
Might also make sense to event this on the IG, for users that aren't cluster operators.
There was a problem hiding this comment.
Yeah, we should pass the IG name from the top level Validate() so we can add the IG name.
Regarding events - yeah, that's a great idea to have events for any IG error associated with the IG for visibility - we might want to do that as a separate effort though across the board.
There was a problem hiding this comment.
Created #304 to address events
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
…/instance-manager into mixed-instances-validation Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror eytan_avisror@intuit.com
Fixes #301
This ignores mixedInstancePolicy spec if it is used along with LaunchConfiguration as spec type.