Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for instance metadata options #305

Merged
merged 3 commits into from
May 17, 2021

Conversation

backjo
Copy link
Collaborator

@backjo backjo commented May 15, 2021

Closes #305

@backjo backjo requested review from a team as code owners May 15, 2021 23:18
Signed-off-by: Jonah Back <jonah@jonahback.com>
@backjo backjo force-pushed the feature/InstanceMetadataOptions branch from 28060d8 to 98cfb41 Compare May 15, 2021 23:18
@codecov
Copy link

codecov bot commented May 15, 2021

Codecov Report

Merging #305 (c93c041) into master (345ef0c) will decrease coverage by 0.01%.
The diff coverage is 69.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
- Coverage   70.06%   70.05%   -0.02%     
==========================================
  Files          19       19              
  Lines        3107     3156      +49     
==========================================
+ Hits         2177     2211      +34     
- Misses        789      804      +15     
  Partials      141      141              
Impacted Files Coverage Δ
api/v1alpha1/instancegroup_types.go 15.08% <0.00%> (-0.05%) ⬇️
api/v1alpha1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
controllers/provisioners/eks/scaling/interface.go 0.00% <ø> (ø)
...rollers/provisioners/eks/scaling/launchtemplate.go 87.93% <80.00%> (-0.75%) ⬇️
controllers/provisioners/eks/create.go 89.42% <100.00%> (+0.20%) ⬆️
...ntrollers/provisioners/eks/scaling/launchconfig.go 92.61% <100.00%> (+0.63%) ⬆️
controllers/provisioners/eks/update.go 80.09% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345ef0c...c93c041. Read the comment docs.

Signed-off-by: Jonah Back <jonah@jonahback.com>
Signed-off-by: Jonah Back <jonah@jonahback.com>
@eytan-avisror
Copy link
Collaborator

LG, added suggestions to move some code to awsprovider

@eytan-avisror
Copy link
Collaborator

eytan-avisror commented May 17, 2021

@backjo nevermind, I see actually in the case of launchtemplate we are placing these constructors within the package.
We can refactor later if it makes sense, for now it's aligned with current patterns.

@backjo backjo merged commit 464de75 into master May 17, 2021
@backjo backjo mentioned this pull request Jun 4, 2021
@tekenstam tekenstam deleted the feature/InstanceMetadataOptions branch September 18, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants