Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add addl tags for scale to 0 support for windows nodes #315

Merged
merged 5 commits into from
Jun 9, 2021

Conversation

backjo
Copy link
Collaborator

@backjo backjo commented Jun 9, 2021

Signed-off-by: Jonah Back jonah@jonahback.com

@backjo backjo requested review from a team as code owners June 9, 2021 03:29
Signed-off-by: Jonah Back <jonah@jonahback.com>
@backjo backjo force-pushed the fix/WindowsAutoscalerAnnotations branch from 339b377 to 6a880c3 Compare June 9, 2021 03:31
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #315 (7cee1d6) into master (ffdd96a) will decrease coverage by 0.06%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
- Coverage   70.20%   70.14%   -0.07%     
==========================================
  Files          19       19              
  Lines        3175     3182       +7     
==========================================
+ Hits         2229     2232       +3     
- Misses        805      809       +4     
  Partials      141      141              
Impacted Files Coverage Δ
controllers/provisioners/eks/helpers.go 91.06% <28.57%> (-0.62%) ⬇️
controllers/provisioners/eks/cloud.go 84.44% <0.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffdd96a...7cee1d6. Read the comment docs.

Signed-off-by: Jonah Back <jonah@jonahback.com>
Signed-off-by: Jonah Back <jonah@jonahback.com>
Signed-off-by: Jonah Back <jonah@jonahback.com>
Copy link
Collaborator

@eytan-avisror eytan-avisror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@backjo backjo merged commit 4bfbdd1 into master Jun 9, 2021
@backjo backjo deleted the fix/WindowsAutoscalerAnnotations branch June 9, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants