Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calculate cluster dns correctly for non /16 blocks #319

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

backjo
Copy link
Collaborator

@backjo backjo commented Jun 29, 2021

Closes #318
Signed-off-by: Jonah Back jonah@jonahback.com

Signed-off-by: Jonah Back <jonah@jonahback.com>
@backjo backjo requested review from a team as code owners June 29, 2021 17:40
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #319 (b93e8b9) into master (a5c9617) will decrease coverage by 14.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #319       +/-   ##
===========================================
- Coverage   70.24%   55.90%   -14.34%     
===========================================
  Files          19       27        +8     
  Lines        3186     4012      +826     
===========================================
+ Hits         2238     2243        +5     
- Misses        808     1628      +820     
- Partials      140      141        +1     
Impacted Files Coverage Δ
controllers/providers/aws/eks.go 4.03% <100.00%> (ø)
controllers/providers/aws/ec2.go 0.00% <0.00%> (ø)
controllers/providers/aws/iam.go 0.00% <0.00%> (ø)
controllers/providers/aws/autoscaling.go 0.00% <0.00%> (ø)
controllers/providers/aws/predicates.go 0.00% <0.00%> (ø)
controllers/providers/aws/aws.go 0.00% <0.00%> (ø)
controllers/providers/aws/retry.go 0.00% <0.00%> (ø)
controllers/providers/aws/constructors.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5c9617...b93e8b9. Read the comment docs.

Copy link
Collaborator

@eytan-avisror eytan-avisror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@backjo backjo merged commit 1e16aff into master Jun 29, 2021
@backjo backjo deleted the fix/ClusterDns branch June 29, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster DNS calculation assumes that service cidr range is /16
2 participants