Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for calculating max pods when prefix assignment is … #326

Merged
merged 5 commits into from
Jul 27, 2021

Conversation

backjo
Copy link
Collaborator

@backjo backjo commented Jul 26, 2021

…enabled

AWS recently released 1.9.0 of the AWS VPC K8S CNI, which adds support for prefix assignment. This PR
allows users who are using prefix assignment to have accurate max-pods calculations through the use of a new annotation on IGs.

https://github.com/aws/amazon-vpc-cni-k8s/releases/tag/v1.9.0

Signed-off-by: Jonah Back jonah@jonahback.com

…enabled

Signed-off-by: Jonah Back <jonah@jonahback.com>
@backjo backjo requested review from a team as code owners July 26, 2021 21:52
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #326 (52e05b6) into master (2d0866e) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 52e05b6 differs from pull request most recent head b963693. Consider uploading reports for the commit b963693 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage   55.94%   56.00%   +0.05%     
==========================================
  Files          27       27              
  Lines        4020     4025       +5     
==========================================
+ Hits         2249     2254       +5     
  Misses       1629     1629              
  Partials      142      142              
Impacted Files Coverage Δ
controllers/provisioners/eks/eks.go 89.13% <ø> (ø)
controllers/provisioners/eks/helpers.go 91.14% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d0866e...b963693. Read the comment docs.

docs/EKS.md Outdated Show resolved Hide resolved
Signed-off-by: Jonah Back <jonah@jonahback.com>
Signed-off-by: Jonah Back <jonah@jonahback.com>
Signed-off-by: Jonah Back <jonah@jonahback.com>
Signed-off-by: Jonah Back <jonah@jonahback.com>
@backjo backjo merged commit fe8b56f into master Jul 27, 2021
@backjo backjo deleted the feature/prefixassignment branch July 27, 2021 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants