Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't set max pods above kubernetes recommended limit #342

Merged
merged 3 commits into from
Feb 4, 2022

Conversation

backjo
Copy link
Collaborator

@backjo backjo commented Feb 4, 2022

Signed-off-by: Jonah Back jonah@jonahback.com

Signed-off-by: Jonah Back <jonah@jonahback.com>
@backjo backjo requested review from a team as code owners February 4, 2022 01:31
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #342 (5c42095) into master (306c823) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #342   +/-   ##
=======================================
  Coverage   51.09%   51.09%           
=======================================
  Files          33       33           
  Lines        4505     4505           
=======================================
  Hits         2302     2302           
  Misses       2062     2062           
  Partials      141      141           
Impacted Files Coverage Δ
controllers/provisioners/eks/helpers.go 91.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 306c823...5c42095. Read the comment docs.

Copy link
Collaborator

@eytan-avisror eytan-avisror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Signed-off-by: Jonah Back <jonah@jonahback.com>
Signed-off-by: Jonah Back <jonah@jonahback.com>
@backjo backjo merged commit 8cda93d into master Feb 4, 2022
@backjo backjo deleted the fix/MaxPods branch February 4, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants