fix: Deduplicate Subnets

[eytan-avisror]

Signed-off-by: Eytan Avisror eytan_avisror@intuit.com

Fixes #339

This ignores duplicate values if provided in subnet field to avoid blocking reconcile.

[codecov]

Codecov Report

Merging #344 (12f5d03) into master (14ffe9c) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
+ Coverage   51.09%   51.15%   +0.05%     
==========================================
  Files          33       33              
  Lines        4505     4510       +5     
==========================================
+ Hits         2302     2307       +5     
  Misses       2062     2062              
  Partials      141      141              

Impacted Files	Coverage Δ
api/v1alpha1/zz_generated.deepcopy.go	0.00% <ø> (ø)
controllers/provisioners/eks/helpers.go	91.45% <100.00%> (+0.05%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14ffe9c...12f5d03. Read the comment docs.

[shailshah9]

LGTM

[backjo]

LGTM. I wonder if it's worth emitting a warning-type event on the IG to give folks a heads up in case they did not intend to supply duplicate values.

[eytan-avisror]

LGTM. I wonder if it's worth emitting a warning-type event on the IG to give folks a heads up in case they did not intend to supply duplicate values.

Yep, our logger right now only has Info() and Error(), but allows for logging levels, we should do some work on logging.
For now emitting an info message.