Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add override instance type for running instances in MixedInstancePolicy #350

Merged

Conversation

eytan-avisror
Copy link
Collaborator

Signed-off-by: Eytan Avisror eytan_avisror@intuit.com
Fixes #349

Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
@eytan-avisror eytan-avisror requested review from a team as code owners February 16, 2022 19:22
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #350 (ff7960a) into master (3adb8e4) will increase coverage by 0.11%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
+ Coverage   51.17%   51.29%   +0.11%     
==========================================
  Files          33       33              
  Lines        4516     4533      +17     
==========================================
+ Hits         2311     2325      +14     
- Misses       2063     2064       +1     
- Partials      142      144       +2     
Impacted Files Coverage Δ
controllers/provisioners/eks/cloud.go 85.77% <71.42%> (-0.43%) ⬇️
controllers/provisioners/eks/helpers.go 91.30% <89.47%> (-0.16%) ⬇️
controllers/provisioners/eks/eks.go 89.58% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3adb8e4...ff7960a. Read the comment docs.

Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
@eytan-avisror eytan-avisror merged commit 798d06d into keikoproj:master Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When switching primaryType with MixedInstances, type is not added to overrides
5 participants