Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use IMDS for autoscaling information #357

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

backjo
Copy link
Collaborator

@backjo backjo commented Apr 12, 2022

Closes #352

@backjo backjo requested review from a team as code owners April 12, 2022 02:03
@backjo backjo force-pushed the feat/GetInstanceAutoScalingStateFromIMDS branch from d8f0b45 to 0902322 Compare April 12, 2022 02:03
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #357 (1a5574f) into master (8084fc4) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
- Coverage   51.44%   51.41%   -0.04%     
==========================================
  Files          33       33              
  Lines        4556     4553       -3     
==========================================
- Hits         2344     2341       -3     
  Misses       2065     2065              
  Partials      147      147              
Impacted Files Coverage Δ
controllers/provisioners/eks/eks.go 89.58% <ø> (ø)
controllers/provisioners/eks/helpers.go 91.66% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8084fc4...1a5574f. Read the comment docs.

Signed-off-by: Jonah Back <jonah@jonahback.com>
@backjo backjo force-pushed the feat/GetInstanceAutoScalingStateFromIMDS branch from 0902322 to 26d23f3 Compare April 12, 2022 02:09
docs/EKS.md Outdated Show resolved Hide resolved
@eytan-avisror
Copy link
Collaborator

Awesome, this makes warm pool support much easier..
Did you get a chance to run this and make sure it works? Not sure if our functional testing covers warm pool or not

@backjo
Copy link
Collaborator Author

backjo commented Apr 12, 2022

Awesome, this makes warm pool support much easier.. Did you get a chance to run this and make sure it works? Not sure if our functional testing covers warm pool or not

I haven't - I believe we have a warm pool TC in the functional tests - was planning to use that to verify. I validated that the IMDS endpoint was returning the expected values on a test instance

Signed-off-by: Jonah Back <jonah@jonahback.com>
@eytan-avisror
Copy link
Collaborator

Awesome, this makes warm pool support much easier.. Did you get a chance to run this and make sure it works? Not sure if our functional testing covers warm pool or not

I haven't - I believe we have a warm pool TC in the functional tests - was planning to use that to verify. I validated that the IMDS endpoint was returning the expected values on a test instance

Yes, looks like we do.. would probably good to do a quick manual test since bdd tests basic CRUD, but I believe if user data fails for any reason node will not join and test will fail, so it should be sufficient

Copy link
Collaborator

@eytan-avisror eytan-avisror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@backjo backjo merged commit 53c5d7a into master Apr 12, 2022
@tekenstam tekenstam deleted the feat/GetInstanceAutoScalingStateFromIMDS branch September 18, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use IMDS for Warm Pools & ASG state
2 participants