Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for container runtime on windows AMIs #359

Merged
merged 2 commits into from
Apr 18, 2022

Conversation

backjo
Copy link
Collaborator

@backjo backjo commented Apr 18, 2022

@backjo backjo requested review from a team as code owners April 18, 2022 13:46
Signed-off-by: Jonah Back <jonah@jonahback.com>
@backjo backjo force-pushed the feature/WindowsContainerRuntime branch from 5274d94 to 08ab9c0 Compare April 18, 2022 13:47
Signed-off-by: Jonah Back <jonah@jonahback.com>
@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #359 (b0a88f2) into master (592d94f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
+ Coverage   51.41%   51.43%   +0.02%     
==========================================
  Files          33       33              
  Lines        4553     4555       +2     
==========================================
+ Hits         2341     2343       +2     
  Misses       2065     2065              
  Partials      147      147              
Impacted Files Coverage Δ
controllers/provisioners/eks/helpers.go 91.68% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 592d94f...b0a88f2. Read the comment docs.

Copy link
Collaborator

@eytan-avisror eytan-avisror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@backjo backjo merged commit 86b7238 into master Apr 18, 2022
@tekenstam tekenstam deleted the feature/WindowsContainerRuntime branch September 18, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants