-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Spot Instances #36
Support Spot Instances #36
Conversation
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=========================================
- Coverage 70.82% 70.52% -0.3%
=========================================
Files 5 6 +1
Lines 682 777 +95
=========================================
+ Hits 483 548 +65
- Misses 139 164 +25
- Partials 60 65 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG. May need to add unit tests to new functions to make ccov pass.
Fantastic! What the expected json payload if the recommendation is to not use spot-instances? |
Will be a recommendation to use on-demand ( |
Fixes #35
This PR adds support for spot-instances with the following implementation:
SpotRecommendationGiven
, the reconciler will reverse lookup the scaling group name from the event'sinvolvedObject.Name
, and find the instance group name and namespace in order to trigger it's reconcile.AwsWorker
object outside of context instead on a later PR.spotPrice
can be set manually in the CR, but will always be overridden by recommendations when it existsstatus
fields -usingSpotRecommendations
andlifecycle
, a printer column was also added forlifecycle
.Testing