Add validation on for VSPs #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrosenberg1
requested review from
eytan-avisror and
nvandanapu
and removed request for
a team
nvandanapu
reviewed
Apr 29, 2022
| return errors.Errorf("validation failed, no policies defined for scale up behavior in spec") | ||
| } | ||
|
|
||
| validPolicyTypes := []UtilizationType{CPUUtilizationPercent, MemoryUtilizationPercent, NodesCountUtilizationPercent} |
There was a problem hiding this comment.
can you make this a constant outside this function?
nvandanapu
reviewed
Apr 29, 2022
| if !isValidUtilizationType(validPolicyTypes, policy.Type) { | ||
| return errors.Errorf("validation failed, invalid policy type %s in scale up behaviors, valid types are: %s", policy.Type, validPolicyTypes) | ||
| } | ||
| if policy.Type == CPUUtilizationPercent || policy.Type == MemoryUtilizationPercent { |
There was a problem hiding this comment.
How about something like if strings.Contains("Percent", policy.Type) instead? To avoid changing code in future when we have more policyTypes
nvandanapu
reviewed
Apr 29, 2022
| @@ -153,3 +154,59 @@ func (status *VerticalScalingPolicyStatus) SetCondition(igName string, condition | |||
| func (status *VerticalScalingPolicyStatus) SetConditions(igName string, conditions []*UtilizationCondition) { | |||
| status.TargetStatuses[igName].Conditions = conditions | |||
| } | |||
|
|
|||
| func (vsp *VerticalScalingPolicy) Validate() error { | |||
There was a problem hiding this comment.
func (vsp *VerticalScalingPolicy) Validate() error {
}
func (spec *VerticalScalingPolicySpec) Validate() error {
}
func (scalingSpec *ScalingSpec) Validate() error {
}
func (policySpec *PolicySpec) Validate() error {
}
nvandanapu
approved these changes
Apr 29, 2022
nvandanapu
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.