fix/373 Replace ARN format validation procedure

[srosenberg-apptio]

Fixes #373

Feedback is welcome.

coverage: 83.8% of statements
ok      github.com/keikoproj/instance-manager/controllers/provisioners/eksmanaged       0.057s  coverage: 83.8% of statements
=== RUN   TestInstanceGroupSpecValidate
=== RUN   TestInstanceGroupSpecValidate/eks-fargate_with_managed_strategy
=== RUN   TestInstanceGroupSpecValidate/eks-bogus_provisioner
=== RUN   TestInstanceGroupSpecValidate/eks-fargate_with_bad_strategy
=== RUN   TestInstanceGroupSpecValidate/eks_with_empty_strings_in_licenseSpecifications
=== RUN   TestInstanceGroupSpecValidate/eks_with_invalid_licenseSpecification
=== RUN   TestInstanceGroupSpecValidate/eks_with_invalid_container_runtime
=== RUN   TestInstanceGroupSpecValidate/eks_with_valid_Placement
=== RUN   TestInstanceGroupSpecValidate/eks_with_invalid_combination_of_HostResourceGroupArn_and_Tenancy_in_Placement
=== RUN   TestInstanceGroupSpecValidate/eks_with_invalid_HostResourceGroupArn_in_Placement
=== RUN   TestInstanceGroupSpecValidate/eks_with_invalid_Tenancy_in_Placement
=== RUN   TestInstanceGroupSpecValidate/eks_with_gp3_volume_validates
=== RUN   TestInstanceGroupSpecValidate/eks_with_gp2_volume_with_provisioned_throughput_fails
=== RUN   TestInstanceGroupSpecValidate/eks_with_gp2_volume_with_provisioned_iops_fails
=== RUN   TestInstanceGroupSpecValidate/eks_with_metadataoptions_validates
=== RUN   TestInstanceGroupSpecValidate/eks_with_valid_configuration_for_any_random_partition
=== RUN   TestInstanceGroupSpecValidate/eks_with_invalid_LicenseSpecifications_for_any_random_partition
=== RUN   TestInstanceGroupSpecValidate/eks_with_invalid_combination_of_HostResourceGroupArn_and_Tenancy_in_Placement_for_any_random_partition
=== RUN   TestInstanceGroupSpecValidate/eks_with_invalid_HostResourceGroupArn_in_Placement_for_any_random_partition
--- PASS: TestInstanceGroupSpecValidate (0.00s)
    --- PASS: TestInstanceGroupSpecValidate/eks-fargate_with_managed_strategy (0.00s)
    --- PASS: TestInstanceGroupSpecValidate/eks-bogus_provisioner (0.00s)
    --- PASS: TestInstanceGroupSpecValidate/eks-fargate_with_bad_strategy (0.00s)
    --- PASS: TestInstanceGroupSpecValidate/eks_with_empty_strings_in_licenseSpecifications (0.00s)
    --- PASS: TestInstanceGroupSpecValidate/eks_with_invalid_licenseSpecification (0.00s)
    --- PASS: TestInstanceGroupSpecValidate/eks_with_invalid_container_runtime (0.00s)
    --- PASS: TestInstanceGroupSpecValidate/eks_with_valid_Placement (0.00s)
    --- PASS: TestInstanceGroupSpecValidate/eks_with_invalid_combination_of_HostResourceGroupArn_and_Tenancy_in_Placement (0.00s)
    --- PASS: TestInstanceGroupSpecValidate/eks_with_invalid_HostResourceGroupArn_in_Placement (0.00s)
    --- PASS: TestInstanceGroupSpecValidate/eks_with_invalid_Tenancy_in_Placement (0.00s)
    --- PASS: TestInstanceGroupSpecValidate/eks_with_gp3_volume_validates (0.00s)
    --- PASS: TestInstanceGroupSpecValidate/eks_with_gp2_volume_with_provisioned_throughput_fails (0.00s)
    --- PASS: TestInstanceGroupSpecValidate/eks_with_gp2_volume_with_provisioned_iops_fails (0.00s)
    --- PASS: TestInstanceGroupSpecValidate/eks_with_metadataoptions_validates (0.00s)
    --- PASS: TestInstanceGroupSpecValidate/eks_with_valid_configuration_for_any_random_partition (0.00s)
    --- PASS: TestInstanceGroupSpecValidate/eks_with_invalid_LicenseSpecifications_for_any_random_partition (0.00s)
    --- PASS: TestInstanceGroupSpecValidate/eks_with_invalid_combination_of_HostResourceGroupArn_and_Tenancy_in_Placement_for_any_random_partition (0.00s)
    --- PASS: TestInstanceGroupSpecValidate/eks_with_invalid_HostResourceGroupArn_in_Placement_for_any_random_partition (0.00s)
=== RUN   TestLockedAnnotation
=== RUN   TestLockedAnnotation/Locked
=== RUN   TestLockedAnnotation/Unlocked
--- PASS: TestLockedAnnotation (0.00s)
    --- PASS: TestLockedAnnotation/Locked (0.00s)
    --- PASS: TestLockedAnnotation/Unlocked (0.00s)
PASS
coverage: 13.0% of statements
ok      github.com/keikoproj/instance-manager/api/v1alpha1      0.074s  coverage: 13.0% of statements
go build -o bin/manager main.go

[eytan-avisror]

Can we also delete the const awsprovider.ARNPrefix since it's not used any longer

[eytan-avisror]

Thanks @srosenberg-apptio
Great fix, minor comment but LGTM otherwise

[codecov]

Codecov Report

Merging #374 (9f8f352) into master (ae893c4) will decrease coverage by 0.02%.
The diff coverage is 60.00%.

❗ Current head 9f8f352 differs from pull request most recent head 4ab98e3. Consider uploading reports for the commit 4ab98e3 to get more accurate results

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
- Coverage   51.43%   51.41%   -0.03%     
==========================================
  Files          33       33              
  Lines        4555     4553       -2     
==========================================
- Hits         2343     2341       -2     
  Misses       2065     2065              
  Partials      147      147              

Impacted Files	Coverage Δ
controllers/providers/aws/aws.go	0.00% <ø> (ø)
api/v1alpha1/instancegroup_types.go	18.69% <50.00%> (ø)
controllers/provisioners/eks/helpers.go	91.66% <100.00%> (-0.03%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[srosenberg-apptio]

Great fix, minor comment but LGTM otherwise

I will apply that fix, and I believe there is another issue I found downstream that I will tackle.

[srosenberg-apptio]

@eytan-avisror
Ready for review. I deployed a build running a cluster in aws-us-gov partition. It did precisely what was expected: created/updated autoscaling groups and launch templates with the appropriate licensing configuration and host tenancy. New nodes were successfully assigned to dedicated hosts.

[eytan-avisror]

LGTM, you might need to rebase/sign your commits so DCO passes

[srosenberg-apptio]

DCO is passing.