Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Not honoring gp3 volume iops and throughput values #380

Merged
merged 3 commits into from
Apr 1, 2023

Conversation

vgunapati
Copy link
Contributor

Fixes #379

@vgunapati vgunapati requested review from a team as code owners April 1, 2023 00:20
Signed-off-by: Venkata Gunapati <venkata_gunapati@intuit.com>
Signed-off-by: Venkata Gunapati <venkata_gunapati@intuit.com>
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/unit-test.yml:unit-test. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #380 (df66e0e) into master (fc56922) will decrease coverage by 0.05%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
- Coverage   51.41%   51.37%   -0.05%     
==========================================
  Files          33       33              
  Lines        4553     4557       +4     
==========================================
  Hits         2341     2341              
- Misses       2065     2069       +4     
  Partials      147      147              
Impacted Files Coverage Δ
controllers/providers/aws/constructors.go 0.00% <0.00%> (ø)
controllers/provisioners/eks/eks.go 89.58% <ø> (ø)
...ntrollers/provisioners/eks/scaling/launchconfig.go 92.61% <100.00%> (ø)
...rollers/provisioners/eks/scaling/launchtemplate.go 87.93% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@eytan-avisror eytan-avisror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We can do a release if you need it and the functional-test is passing

@vgunapati
Copy link
Contributor Author

Looks like functional-test is broken for a while, Do we have a doc on how to set this up if the cluster is deleted

@eytan-avisror
Copy link
Collaborator

No doc, but it pretty much needs a vanilla EKS cluster + upgrade manager

@vgunapati
Copy link
Contributor Author

I don't have access to the settings page to update Access keys, I will follow up with the team

@vgunapati vgunapati merged commit 7ebd7f2 into keikoproj:master Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not honoring gp3 volume iops and throughput values
2 participants