Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect counter name #409

Merged
merged 2 commits into from
Oct 13, 2023
Merged

fix incorrect counter name #409

merged 2 commits into from
Oct 13, 2023

Conversation

ZihanJiang96
Copy link
Member

No description provided.

@ZihanJiang96 ZihanJiang96 requested review from a team as code owners October 13, 2023 17:34
@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Merging #409 (9cce53a) into master (ff2538b) will not change coverage.
The diff coverage is n/a.

❗ Current head 9cce53a differs from pull request most recent head 388d0c8. Consider uploading reports for the commit 388d0c8 to get more accurate results

@@           Coverage Diff           @@
##           master     #409   +/-   ##
=======================================
  Coverage   50.13%   50.13%           
=======================================
  Files          33       33           
  Lines        6297     6297           
=======================================
  Hits         3157     3157           
  Misses       2991     2991           
  Partials      149      149

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sbadla1
sbadla1 approved these changes Oct 13, 2023
View reviewed changes
Copy link

@sbadla1 sbadla1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yuxuanzhu0214
yuxuanzhu0214 reviewed Oct 13, 2023
View reviewed changes
Copy link

@yuxuanzhu0214 yuxuanzhu0214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might also need to pass in the reason label since failureCounter has that when initialized.

@ZihanJiang96 ZihanJiang96 enabled auto-merge (squash) October 13, 2023 18:07
@ZihanJiang96 ZihanJiang96 merged commit 31e3a1f into master Oct 13, 2023
3 checks passed
@ZihanJiang96 ZihanJiang96 deleted the ZihanJiang96-patch-1 branch October 13, 2023 18:07
@shreyas-badiger shreyas-badiger mentioned this pull request Oct 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuxuanzhu0214 yuxuanzhu0214 yuxuanzhu0214 left review comments

@shreyas-badiger shreyas-badiger shreyas-badiger approved these changes

@sbadla1 sbadla1 sbadla1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ZihanJiang96 @shreyas-badiger @yuxuanzhu0214 @sbadla1