Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed node groups #76

Merged
merged 9 commits into from
Mar 3, 2020

Conversation

eytan-avisror
Copy link
Collaborator

@eytan-avisror eytan-avisror commented Mar 2, 2020

Fixes #69

Initial Implementation of managed node groups

@eytan-avisror eytan-avisror requested a review from a team as a code owner March 2, 2020 06:27
@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@92dc707). Click here to learn what that means.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #76   +/-   ##
=========================================
  Coverage          ?   73.59%           
=========================================
  Files             ?        8           
  Lines             ?     1015           
  Branches          ?        0           
=========================================
  Hits              ?      747           
  Misses            ?      201           
  Partials          ?       67
Impacted Files Coverage Δ
...rollers/provisioners/ekscloudformation/strategy.go 56.93% <100%> (ø)
...rovisioners/ekscloudformation/ekscloudformation.go 82.13% <60%> (ø)
controllers/provisioners/eksmanaged/eksmanaged.go 78.52% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92dc707...663379f. Read the comment docs.

@eytan-avisror eytan-avisror merged commit 5a6f76d into keikoproj:master Mar 3, 2020
@eytan-avisror eytan-avisror mentioned this pull request Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support managed worker node group for EKS
2 participants