Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

Cordon and drain nodes before termination #19

Closed
shrinandj opened this issue Jan 8, 2019 · 0 comments
Closed

Cordon and drain nodes before termination #19

shrinandj opened this issue Jan 8, 2019 · 0 comments
Assignees
@shrinandj

Comments

@shrinandj
Copy link
Collaborator

When the minion-manager switches between on-demand to spot instances, it currently simply terminates the nodes. It will be good if the termination is proceeded by cordoning and draining the node so that the pods on that node can move to a different node. Also, this might reduce the downtime (if any) that the apps might face because of this.
@shrinandj shrinandj mentioned this issue Feb 9, 2019
Closed
@shrinandj shrinandj self-assigned this Feb 9, 2019
shrinandj added a commit to shrinandj/minion-manager that referenced this issue Feb 11, 2019
@shrinandj
Cordon and drain nodes before terminating.
860e80b 
Testing Done:

- Added unit tests.
- Verified on a real-cluster that the nodes were cordoned and drained.

Closes keikoproj#19.
@shrinandj shrinandj mentioned this issue Feb 11, 2019
Merged
shrinandj added a commit that referenced this issue Feb 15, 2019
@shrinandj
Cordon and drain nodes before terminating. (#21)
ad69c2a 
Testing Done:

- Added unit tests.
- Verified on a real-cluster that the nodes were cordoned and drained.

Closes #19.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shrinandj shrinandj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shrinandj