Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a command option name to be consistent with kubectl #2

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Fix a command option name to be consistent with kubectl #2

merged 2 commits into from
Aug 12, 2021

Conversation

hidetatz
Copy link
Contributor

kubectl-secret-data has a option --all-namespace, but it should be --all-namespaces because it is more consistent with kubectl. The difference of trailing "s" might confuse users who are used to the kubectl.

kubectl uses --all-namespaces like below:

$ kubectl get -h | grep all-namespace
 Prints a table of the most important information about the specified resources. You can filter the list using a label selector and the --selector flag. If the desired resource type is namespaced you will only see results in your current namespace unless you pass --all-namespaces.
  -A, --all-namespaces=false: If present, list the requested object(s) across all namespaces. Namespace in current context is ignored even if specified with --namespace.

Copy link
Owner

@keisku keisku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@keisku keisku merged commit 326f774 into keisku:main Aug 12, 2021
@hidetatz hidetatz deleted the fix/usage branch August 12, 2021 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants