Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking this while using Browserslist API #37

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

ai
Copy link
Contributor

@ai ai commented Sep 25, 2024

Calling { key } destroys this binding in Browserslist which lead to issues like browserslist/browserslist#845

Note, that browserslist/node is private API, you should use just browserslist.findConfig (I will create a separated issue to discuss this changes).

@ai ai changed the title Fix breakins this while using Browserslist API Fix breaking this while using Browserslist API Sep 25, 2024
Copy link
Owner

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks @ai!

@keithamus keithamus merged commit e2d05fa into keithamus:main Sep 25, 2024
1 check passed
@ai
Copy link
Contributor Author

ai commented Sep 25, 2024

It was very quick! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants