Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decorating error with dependencies bound with FastBind() #12

Merged
merged 3 commits into from
Dec 1, 2024

Conversation

kekchpek
Copy link
Owner

@kekchpek kekchpek commented Dec 1, 2024

FastBind() had used a casting to implementation class during adding dependency to ViewModels container. This casting was used in the provider-method, that had being added to ViewModels container to get the dependency from main container. It had raised an error on attempt to decorate any dependency, that is bound this way, because decorator is not an inheritor of decorated class. So the decorator could not be casted to original implementation class.

Now FastBind() do not use data about implementation this way and do not make any checks in ViewModels container provider-method.

Decorating example was added to demo project to keep autotests catch errors in this functionality.

@kekchpek kekchpek merged commit 6ba741e into develop Dec 1, 2024
1 check passed
@kekchpek kekchpek deleted the feature/decoratable-view-manager branch December 1, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant