-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nullable reference types #121
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec27507
to
9bd23ce
Compare
maxkatz6
reviewed
May 23, 2024
maxkatz6
reviewed
May 23, 2024
maxkatz6
reviewed
May 23, 2024
maxkatz6
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables nullable reference types in all XamlX projects.
Most Avalonia projects now use nullable annotations, but some core ones such as
Markup.Xaml.Loader
can't because XamlX isn't nullable aware. This PR fixes that.Notable changes:
DeclaringType
is now non-null and exposed onIXamlMember
directly.GetMethod
overloads matching theFindMethod
ones have been added and used in place ofFindMethod
, as most places in emit code expected methods to actually be found.TypeReferenceResolver.ResolveType
returns a non null type. There were some code paths accepting null, but at the end of the dayResolveTypeCore
was called which throws if the type couldn't be resolved, which callers expected.CecilType.GetEnumUnderlyingType
andCecilField.GetLiteralValue
now throw instead of returning null for non-enum/literal. This matches the SRE implementation.