Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebuild binaries for Node 12 LTS (v72) #721

Closed
madmoizo opened this issue Apr 25, 2019 · 14 comments
Closed

Prebuild binaries for Node 12 LTS (v72) #721

madmoizo opened this issue Apr 25, 2019 · 14 comments

Comments

@madmoizo
Copy link

Currently, bcrypt requires a manual build to work with the latest Node 12

@recrsn
Copy link
Collaborator

recrsn commented Apr 25, 2019

It's because Node 12 was released very recently and I haven't got the time to generate a prebuilt binary unfortunately

@madmoizo
Copy link
Author

I know, don't worry, it's nothing more than a reminder ;)

@tmirun
Copy link

tmirun commented May 3, 2019

Same problem, i am waiting too =)

@CherryNerd
Copy link

Any idea when it'll be ready to use?
I'd like to be able to use the faster async/await and other V8 improvements of Node 12 :)

@recrsn
Copy link
Collaborator

recrsn commented May 8, 2019

@CherryNerd You can use it, just install dependencies for source compile. A cyclone hit my city and currently, I am stuck at a place with no power and really poor internet, I cannot promise any ETA about when I would be able to provide a pre-compiled binary for Node 12.

@tmirun
Copy link

tmirun commented May 8, 2019

@agathver I hope you are well

@tmirun
Copy link

tmirun commented May 8, 2019

@frlinw can you write how to build it manually for the latest Node 12, I start a project with electron 5 and it only working with node 12 =(
ty guy

@madmoizo
Copy link
Author

madmoizo commented May 8, 2019

@tmirun it's in the README: install dependencies then update bcrypt and it will try to build it https://github.com/kelektiv/node.bcrypt.js#dependencies
Note:
Requirement for node-gyp: https://github.com/nodejs/node-gyp#on-windows

(Node 12 installer should ask you if you want to install node-gyp and its dependencies)

@tmirun
Copy link

tmirun commented May 8, 2019

@frlinw Oh, right, ty guy I will try it =)

angristan added a commit to fight-food-waste/api that referenced this issue Jul 1, 2019
thetutlage added a commit to adonisjs/hash that referenced this issue Jul 12, 2019
Bcrypt fails on Node v12 and there are related open issues for same
kelektiv/node.bcrypt.js#728 and kelektiv/node.bcrypt.js#721. Let's wait for them to get fixed
@netok421
Copy link

Will this be fixed?

@ayZagen
Copy link

ayZagen commented Oct 30, 2019

Nodejs v12 is promoted to be LTS. I think it is time for bcrypt should support v12

@recrsn recrsn closed this as completed Feb 17, 2020
@orgads
Copy link

orgads commented Jun 1, 2020

ping?

@orgads
Copy link

orgads commented Jun 1, 2020

Why was this closed?

@recrsn
Copy link
Collaborator

recrsn commented Jun 1, 2020

@orgads See #796

Prebuilt libraries are available, NodeJS update has broken the download mechanism. But it is fixed in v5.0.0 which will be released soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants