Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[noticket] Add fix for devenv usage outside of project folder #52

Merged
merged 5 commits into from
May 8, 2023

Conversation

lx-wnk
Copy link
Contributor

@lx-wnk lx-wnk commented May 4, 2023

1. Why is this change necessary?

If devenv is placed in the parent folder of the project - whyever - this will result in an exit instead of keeping the project running

2. What does this change do, exactly?

Switch an exit with a sleep

3. Describe each step to reproduce the issue or behaviour.

Setup a new project, run and setup it initially and restart devenv

4. Please link to the relevant issues (if any).

///

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written or adjusted the documentation according to my changes

@lx-wnk lx-wnk requested a review from jochenmanz May 4, 2023 10:26
@lx-wnk lx-wnk self-assigned this May 4, 2023
devenv.nix Outdated Show resolved Hide resolved
@lx-wnk lx-wnk requested a review from kleinmann May 4, 2023 11:07
@lx-wnk lx-wnk force-pushed the noticket/fix-exit-for-wrapped-projects branch from 7b2dd45 to 97a263b Compare May 4, 2023 11:14
@lx-wnk lx-wnk force-pushed the noticket/fix-exit-for-wrapped-projects branch from 97a263b to 97d6f99 Compare May 4, 2023 11:14
@lx-wnk lx-wnk removed the request for review from jochenmanz May 8, 2023 14:47
@lx-wnk lx-wnk merged commit f9acbda into main May 8, 2023
@lx-wnk lx-wnk deleted the noticket/fix-exit-for-wrapped-projects branch May 8, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants