feat(Tidal): format textual copyright symbols as © or ℗ #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a utility function formatCopyrightSymbols to handle this and use it also in the Spotify implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Tidal it s very common to have copyright symbols in textual form, e.g. "(p)" or "(C)", instead of the dedicated symbols ℗ or ©. The symbols are also used, but it is not mandatory.
Add a utility function
formatCopyrightSymbolsto handle this. Also use this function in the existing Spotify implementation for copyright cleanup.This PR partially but not completely addresses #23. I wanted to fix the most prominent issue where Tidal shows "(p) 2024 Some Band", but Spotify and iTunes give "℗ 2024 Some Band". Now there is a single consistent copyright entry.
Previously for https://tidal.com/album/64944658:
Now:
What this PR does not address: