Support standalone Bandcamp tracks #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiencek
commented
May 28, 2024
| throw new ProviderError(this.provider.name, `${specifier} is not a release URL`); | ||
| } | ||
| this.lookup = { method: 'id', value: entity.id }; | ||
| this.id = entity.id; |
There was a problem hiding this comment.
I assigned the id here so that I could access it in getRawRelease. Is the assignment in convertRawRelease still needed?
There was a problem hiding this comment.
I don't think so, no idea why I haven't made this assignment in the constructor right from the start 😇
Looks like this is worth to be changed in all provider implementations.
mwiencek
force-pushed
the
bandcamp-track
branch
2 times, most recently
from
a9a1c11 to
6f4dead
Compare
kellnerd
requested changes
May 28, 2024
| throw new ProviderError(this.provider.name, `${specifier} is not a release URL`); | ||
| } | ||
| this.lookup = { method: 'id', value: entity.id }; | ||
| this.id = entity.id; |
There was a problem hiding this comment.
I don't think so, no idea why I haven't made this assignment in the constructor right from the start 😇
Looks like this is worth to be changed in all provider implementations.
mwiencek
force-pushed
the
bandcamp-track
branch
2 times, most recently
from
bea9be8 to
3c799be
Compare
kellnerd
approved these changes
May 28, 2024
Some `/track/` URLs on Bandcamp represent singles (often with their own cover art) that aren't otherwise released as part of an album. It seems you can distinguish these from album tracks by checking `TrAlbumCurrent.album_id`, which is `null` for tracks without an associated album. (Perhaps there is another, more obvious way that I missed.)
Bandcamp `/track/` URLs may include an ISRC in `TrAlbumCurrent`.
Handle `null` and missing values for release date, GTIN and track number.
The original thought was not to seed edit notes with localhost URLs, but this can also happen with a local production server, not only with a development server. It is rather useful being able to check the permalinks in development.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
/track/URLs on Bandcamp represent singles (often with their own cover art) that aren't otherwise released as part of an album.It seems you can distinguish these from album tracks by checking
TrAlbumCurrent.album_id, which isnullfor tracks without an associated album. (Perhaps there is another, more obvious way that I missed.)In the second commit, I was able to extract an ISRC for these tracks where available. (Apparently Bandcamp only embeds ISRCs on track pages, not album pages?)
This is probably very hacky since I was still trying to wrap my head around the codebase, but I'm happy to improve it.
A few URLs I tested with: