Skip to content
This repository has been archived by the owner on Dec 24, 2018. It is now read-only.

Prevent ember-cli watcher being assigned to node_modules #62

Merged
merged 3 commits into from
Aug 19, 2017

Conversation

jasonmit
Copy link
Contributor

@jasonmit jasonmit commented Jun 27, 2017

Fixes #61

Also went ahead and removed the addon folder since the presence of it causes warnings in the parent project:

DEPRECATION: Addon files were detected in `/Users/jasonmit/projects/foo/node_modules/ember-cli-node-modules-to-vendor/addon`, but no JavaScript preprocessors were found for `ember-cli-node-modules-to-vendor`. Please make sure to add a preprocessor (most likely `ember-cli-babel`) to in `dependencies` (NOT `devDependencies`) in `ember-cli-node-modules-to-vendor`'s `package.json`.

@kellyselden
Copy link
Owner

Mind removing the yarn file, then we will get this merged.

@jasonmit
Copy link
Contributor Author

@kellyselden done

@kellyselden kellyselden merged commit cc8f011 into kellyselden:master Aug 19, 2017
@kellyselden
Copy link
Owner

Thank you!

@kellyselden
Copy link
Owner

Released in v0.2.2

@jasonmit jasonmit deleted the unwatch-folders branch August 21, 2017 19:31
@stefanpenner
Copy link

stefanpenner commented Aug 23, 2017

I would prefer sane be fixed, then going around patching all libraries to not-watch. Fixing sane will have much better impact.

I spike a WIP in Jan, just haven't had much time to make it not mega shitty: amasad/sane#83

But it more or less completely addresses slow startup times do to excessive watch-roots.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants