-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow proper use of etcd proxies. #329
Conversation
I've actually just gone ahead and added some code that automatically prepends the scheme. |
I think with etcdctl they call this |
Seems reasonable to me. |
Fixes #354 for me. |
+1 |
This should be fixed with the move to the new etcd client libs. Please feel free to reopen if that is not the case. |
This is not resolved. I'm still hitting that issue. Any URL options I need to pass? I don't see any relevant CLI flags. Using 0.11 |
The new etcd client lib is included in the 0.12 pre-releases. 0.11 still Jerome Gravel-Niquet notifications@github.com schrieb am Di., 27. Sep.
|
@HeavyHorst oh, you're right. I just tried it and it seems to work, mostly. The initial lookup works, as well as the subsequent ones when watching. Which is what troubles me given my logs are being spammed with:
It works though, which is conflicting with those messages. It's worth noting I current use a 2 proxy setup, through https, I provide a client-ca-keys argument, a username and a password. |
I noticed that the Error occurs every 8 seconds. The etcd-watcher uses http Jerome Gravel-Niquet notifications@github.com schrieb am Mi., 28. Sep.
|
I believe I'm hitting this issue: etcd-io/etcd#3405 I've looked at the proxies' logs and all I see are those premature closed connections (at the same interval you mentioned):
Could be an issue with compose.io though (that's where my etcd is.) |
Looks like this may be related too: etcd-io/etcd#3894 (which is fixed by: etcd-io/etcd#4254) :thinkingface: |
@jeromegn i can reproduce the error with a newly created compose.io etcd cluster. I think it should be sufficient to bump the etcd client to the latest version. |
Resolves #319.
This pull request adds a
--no-discover
flag that applies only when using the etcd backend. This flag prevents confd from discovering the whole cluster, and so ensures that it only uses the proxy.This change may be incomplete: right now with the change in this form you need to provide the etcd authority in the form
http://host:port
when using the--no-discover
flag. If that's problematic, we can copy go-etcd'sClient.createHttpPath
method, which can add a scheme to the front of the authority if needed. Thoughts?