Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix env variable KUBERNETES_PUBLIC_ADDRESS #312

Closed

Conversation

alban
Copy link

@alban alban commented Feb 6, 2018

Symptoms:

$ echo $KUBERNETES_PUBLIC_ADDRESS
kubernetes-the-hard-way

With this patch, I get the IP address instead of the name.

Symptoms:
$ echo $KUBERNETES_PUBLIC_ADDRESS
kubernetes-the-hard-way

With this patch, I get the IP address instead of the name.
@alban
Copy link
Author

alban commented Feb 6, 2018

Oops I missed the discussion in #299 and #282 that says it works both ways anyway.

Since $KUBERNETES_PUBLIC_ADDRESS is the IP in other part of the doc, including in the same file, I think it's better to use the IP though.

@kelseyhightower
Copy link
Owner

I'll now use address everywhere to avoid confusion. This is fixed on the 1.10.2 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants