Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating Fully Functional Docker Image #19

Closed
wants to merge 1 commit into from
Closed

Creating Fully Functional Docker Image #19

wants to merge 1 commit into from

Conversation

taiidani
Copy link

@taiidani taiidani commented Feb 7, 2018

Fixes #18

@hypersleep
Copy link

Such a great work! Thank you so much @taiidani !

@Redmega
Copy link

Redmega commented Feb 7, 2018

This is code

taiidani referenced this pull request Feb 7, 2018
@kelseyhightower
add Docker support
ed6c73f
lattwood
lattwood suggested changes Feb 7, 2018
View reviewed changes
Copy link

@lattwood lattwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is code

drewcassidy
drewcassidy suggested changes Feb 7, 2018
View reviewed changes
Dockerfile
@@ -0,0 +1 @@
FROM scratch
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is code, please remove

singhai0
singhai0 suggested changes Feb 7, 2018
View reviewed changes
Copy link

@singhai0 singhai0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:g/FROM scratch/d

@taiidani
Copy link
Author

taiidani commented Feb 8, 2018

Closing due to Kelsey already making this change to master outside PR. Good times!

@taiidani taiidani closed this Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewcassidy drewcassidy drewcassidy requested changes

@lattwood lattwood lattwood requested changes

@singhai0 singhai0 singhai0 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@taiidani @hypersleep @Redmega @drewcassidy @lattwood @singhai0