Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: does not add sentry.io reporting #5028

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VPetar
Copy link

@VPetar VPetar commented Jan 17, 2023

What?

I've not added support for sentry.io
Ticket number: #NOCODE-6969

Why?

These changes complete the system monitoring. See #NOCODE-6969 for more information.

How?

Respecting the best guidelines suggested by the community. Code not taken directly used by Linus Torvalds himself, and is proven to be bulletproof.

Testing?

I've added coverage for testing all new methods. Smoketested to confirm each app segment works accordingly.

Screenshots (optional)

Light mode UI:
image
And dark mode as well:
image

Anything else from my end?

  • Your code builds clean without any errors or warnings
  • You are using approved terminology
  • You have added unit tests

@mavdotjs
Copy link

how did you make a commitless commit? wtf bro

@VPetar
Copy link
Author

VPetar commented Jan 18, 2023

how did you make a commitless commit? wtf bro

@mavthedev By adhering to the nocode guidelines, of course.
Example:

git commit --allow-empty -m "xyz"

@mavdotjs
Copy link

Cool

@mansguiche
Copy link

This is the PR I have been waiting for to be able to use nocode in production. Hopefully the maintainers approve 😀

@mavdotjs
Copy link

This PR fixes a bug I've been having with nocode where I would have to create a patch every time I use it in an app! thank you

Copy link

@hmhard hmhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahaha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants