Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cordova prepare does not run after_prepare if hook is in platform element #17

Closed
ippeiukai opened this issue Dec 4, 2017 · 2 comments
Closed

cordova prepare does not run after_prepare if hook is in platform element #17

ippeiukai opened this issue Dec 4, 2017 · 2 comments

Comments

@ippeiukai
Copy link
Contributor

After cloning our repository, we run cordova prepare.
With after_prepare hooks in platform element of plugin.xml, this does not work because it only gets triggered by platform specified calls (e.g. cordova prepare ios).

FYR there was similar issue with another project: akofman/cordova-plugin-add-swift-support#3 (comment)
ippeiukai added a commit to ippeiukai/cordova-plugin-localization-strings that referenced this issue Dec 4, 2017
@ippeiukai
after_prepare hook to be outside the platform element in plugin.xml
84d306e 
kelvinhokk#17
@ippeiukai ippeiukai mentioned this issue Dec 4, 2017
Merged
@kelvinhokk
Copy link
Owner

Thanks for the pull request, will give it a run through to do a quick test before merging later.

@kelvinhokk
Copy link
Owner

This has been pull and merged into master

@jskrepnek jskrepnek mentioned this issue Nov 15, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ippeiukai @kelvinhokk