Skip to content
This repository has been archived by the owner on Jan 6, 2019. It is now read-only.

Workaround for Windows 8/8.1 and 10 notifications #18

Merged
merged 1 commit into from
Jun 24, 2018

Conversation

brandoningli
Copy link
Contributor

Added setAppUserModelId statements to the Windows build. End user must add a shortcut to Start Menu folder. This workaround ended up working for me on another app, but I don't have enough friends using Allo to test this fix on this particular app. :)

Added setAppUserModelId statements to the Windows build. End user must add a shortcut to Start Menu folder.
@brandoningli
Copy link
Contributor Author

It doesn't hold them in the Action Center for some reason, though. Not sure how to account for that.

@brandoningli
Copy link
Contributor Author

brandoningli commented Jun 21, 2018

Update: The setting to Show notifications in action center was off by default in the windows Settings app. So they should stick with this setting on. 😄

This might not show up until a notification is received, though.

@kelyvin kelyvin merged commit e43543c into kelyvin:master Jun 24, 2018
@kelyvin
Copy link
Owner

kelyvin commented Jun 24, 2018

Wow thanks a bunch for making all of these changes!!! I have merged your changes in and will include them in the release.

Thanks!

@brandoningli
Copy link
Contributor Author

I don't know why git insists on saying there were 22 changes per file. I only added one line to each of those files, and it said I changed blank lines. Must be a Windows thing. Regardless, thanks for the kind words.

@AdrianoCahete
Copy link

I don't know why git insists on saying there were 22 changes per file. I only added one line to each of those files, and it said I changed blank lines. Must be a Windows thing. Regardless, thanks for the kind words.

Your code editor might been stripping spaces on blank lines (VS Code, maybe?). It's good, 'cause it's cleaning the file. :P

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants