Skip to content

Commit

Permalink
Set image versions to major or minor only (#247)
Browse files Browse the repository at this point in the history
PR removes specificity of base image versions where possible, preferring
to specify only the major or minor version but removing all patch
versions. This should give the image pull the flexibility to pull
slightly updated versions.
  • Loading branch information
kenellorando authored Mar 28, 2023
2 parents 3628000 + dbc73eb commit de8cd95
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions cadence/cadence-multiarch.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
# syntax=docker/dockerfile:1
FROM --platform=${BUILDPLATFORM:-linux/amd64} golang:1.20.1-bullseye as builder
FROM --platform=${BUILDPLATFORM:-linux/amd64} golang:1.20-bullseye as builder
ARG TARGETPLATFORM BUILDPLATFORM TARGETOS TARGETARCH
WORKDIR /cadence
COPY ./* ./
RUN go mod download
RUN CGO_ENABLED=0 GOOS=${TARGETOS} GOARCH=${TARGETARCH} go build -ldflags="-w -s" -o /cadence-server

ARG ARCH=
FROM ${ARCH}golang:1.20.1-alpine
FROM ${ARCH}golang:1.20-alpine
LABEL maintainer="Ken Ellorando (kenellorando.com)"
LABEL source="github.com/kenellorando/cadence"
COPY --from=builder /cadence/public /cadence/server/public
Expand Down
2 changes: 1 addition & 1 deletion cadence/cadence.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# syntax=docker/dockerfile:1
ARG ARCH=
FROM ${ARCH}golang:1.20.1-bullseye
FROM ${ARCH}golang:1.20-bullseye
LABEL maintainer="Ken Ellorando (kenellorando.com)"
LABEL source="github.com/kenellorando/cadence"
WORKDIR /cadence/server
Expand Down
2 changes: 1 addition & 1 deletion cadence/icecast2.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# syntax=docker/dockerfile:1
ARG ARCH=
FROM ${ARCH}alpine:3.17
FROM ${ARCH}alpine:3
LABEL maintainer="Ken Ellorando (kenellorando.com)"
LABEL source="github.com/kenellorando/cadence"
RUN apk update && apk add icecast=2.4.4-r8
Expand Down
2 changes: 1 addition & 1 deletion cadence/liquidsoap.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# syntax=docker/dockerfile:1
ARG ARCH=
FROM ${ARCH}debian:11.6-slim
FROM ${ARCH}debian:11-slim
LABEL maintainer="Ken Ellorando (kenellorando.com)"
LABEL source="github.com/kenellorando/cadence"

Expand Down

0 comments on commit de8cd95

Please sign in to comment.