[pull] rolling from ament:rolling #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This makes the `run_test.py` wrapper aware of the `SKIP_RETURN_CODE` property on CTest tests. In the existing implementation, the wrapper detects that no result file was generated and overrides the special return code coming from the test, making the the CTest feature fail completely. This change makes the wrapper script aware of the special return code, and when detected, will write a 'skipped' result file instead of a 'failed' result file, and pass along the special return code as-is. Now the gtest result and the ctest results both show the test as 'skipped' when the special return flag is used. Note that none of this behavior is enabled by default, which is important because we wouldn't want a test to fail and return a code which we've decided is the special 'skip' return code. Only tests which are aware of this feature should use it. Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
* ensure gtest to consume the correct headers. Signed-off-by: seanyen <seanyen@microsoft.com> * add another patch. Signed-off-by: seanyen <seanyen@microsoft.com>
* Add actual test time to xUnit result files Fixes #269 Signed-off-by: ruffsl <roxfoxpox@gmail.com> * Report test_time even with skipped test Signed-off-by: ruffsl <roxfoxpox@gmail.com> * Set time attribute for testcase element Signed-off-by: ruffsl <roxfoxpox@gmail.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Scott K Logan <logans@cottsay.net>
Previously, I assumed all results generated by Google Benchmark were of 'iteration' type. Now that I have more experience with Google Benchmark, I've started generating aggregate results, which contain some different properties. This change adds support for aggregate results and should make it easy to add any other result schemas we encounter in the future. For forward-compatibility, unsupported types will generate a warning message but will not fail the test. This makes the conversion tolerant to Google Benchmark adding new measures for existing mechanisms. Signed-off-by: Scott K Logan <logans@cottsay.net>
These tests can be fairly heavy, so we don't want to run them by default. It would be better if there was a way to skip the tests by default in such a way that they could be specifically un-skipped at runtime, but I can't find a mechanism in CMake or CTest that would allow us to achieve that behavior without leveraging environment variables. Signed-off-by: Scott K Logan <logans@cottsay.net>
This is a follow-up to c67cdf2. When the SKIP_RETURN_CODE gets set to 0, the value is interpreted as 'false', and the test property is never actually added. Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
The condition attribute was already parsed when reading the XML file. Just needed to check the condition when adding dependencies to the list for a particular key/target. Fixes #266 Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
* Check condition attr in package.xml dependencies The condition attribute was already parsed when reading the XML file. Just needed to check the condition when adding dependencies to the list for a particular key/target. Fixes #266 Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org> * Address Dirk's code review feedback Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* fix imported targets with multiple configuration Signed-off-by: Csaba Sipos <siposcsaba89@gmail.com> * taking into account DEBUG_CONFIGURATIONS global variable Signed-off-by: Csaba Sipos <siposcsaba89@gmail.com>
Signed-off-by: Scott K Logan <logans@cottsay.net>
Follow-up to a5fb311 Signed-off-by: Scott K Logan <logans@cottsay.net>
This change will handle runtime failures in Google Benchmark by propagating error information from Google Benchmark to both CTest and the Jenkins benchmark plugin. Signed-off-by: Scott K Logan <logans@cottsay.net>
convert to string instead Signed-off-by: Csaba Sipos <siposcsaba89@gmail.com>
* Add SYSTEM keyword option to ament_target_dependencies Signed-off-by: Andre Nguyen <anguyen@applanix.com> * Add documentation of SYSTEM keyword for ament_target_dependencies Signed-off-by: Andre Nguyen <anguyen@applanix.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
…#300) * [ament_cmake_python] make the ament_cmake_python_get_python_install_dir a public interface. Signed-off-by: Maximilien Naveau <maximilien.naveau@tuebingen.mpg.de>
Signed-off-by: ahcorde <ahcorde@gmail.com>
google/googletest#1303 Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
The comment in the commit explains the reasoning behind it. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Scott K Logan <logans@cottsay.net>
Evidently 'release' isn't a config keyword, but 'general' is. I also modified the test to assert that the keyword is actually treated like a keyword. Signed-off-by: Scott K Logan <logans@cottsay.net>
When patch files are changed, re-download the sources to get a clean slate to re-apply the changed patch files. Signed-off-by: Scott K Logan <logans@cottsay.net>
* CMAKE_FIND_DEBUG_MODE: Similar to CMAKE_VERBOSE_MAKEFILE, this flag causes CMake to generate additional console output. * CMAKE_MODULE_PATH: Similar to CMAKE_PREFIX_PATH, this list of directories can be used to help CMake search additional locations for package finding modules. Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Marco A. Gutierrez <marcogg@marcogg.com>
Signed-off-by: Vincent Richard <vincent.francois.richard@gmail.com> Signed-off-by: Scott K Logan <logans@cottsay.net> Co-authored-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Marco A. Gutierrez <marcogg@marcogg.com>
Signed-off-by: Marco A. Gutierrez <marcogg@marcogg.com>
This is necessary when using ament_generate_version_header() with a target that is an INTERFACE library, so that it actually gets built. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Kevin Egger <kevin.egger@sevensense.ch>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
This should prevent pytest invocations via ament_add_pytest_test from writing __pycache__ directories into the package sources. Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Fix appending search paths specified by GTEST_DIR that was being overridden by the set command for system paths Signed-off-by: William Wedler <william.wedler@videoray.com> Co-authored-by: William Wedler <william.wedler@videoray.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
The vcstool package can be used with multiple package managers, not just git. Best to be explicit about which of those package managers we want to use. Signed-off-by: Scott K Logan <logans@cottsay.net>
Follow-up to 0fd5578 Signed-off-by: Scott K Logan <logans@cottsay.net>
During non-symlink install, these files are copied to the install prefix by default. We should do the same for symlink installs if they're specified. Signed-off-by: Scott K Logan <logans@cottsay.net>
Generator expressions are supported when invoking install(FILES) normally, and this change adds support for such invocations when symlinking as well. The change is copied from ament_cmake_symlink_install_targets, which already performs this resolution successfully. Signed-off-by: Scott K Logan <logans@cottsay.net>
They are both outdated and both no longer serving their intended purpose. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Ezra Brooks <ezra@brooks.cx>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )