Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sampling method #27

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Improve sampling method #27

merged 3 commits into from
Apr 22, 2024

Conversation

kenki931128
Copy link
Owner

Description

What is the context? (Why these changes are required?)
Improve the sampling method

What has been changed?

  1. sampled y is larger than 0
  2. intervention_effect should be %. 1 means no effect. if 5 % uplift, intervention_effect should be 1.05
  3. scale variable can be the scale of y-axis.

@kenki931128 kenki931128 added the enhancement New feature or request label Apr 22, 2024
@kenki931128 kenki931128 self-assigned this Apr 22, 2024
@kenki931128 kenki931128 merged commit 99da332 into develop Apr 22, 2024
8 checks passed
@kenki931128 kenki931128 deleted the feature/improve-sampling-method branch April 22, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kenki931128 kenki931128

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kenki931128