Skip to content

Commit

Permalink
fix(masthead): update logo url protocol (carbon-design-system#9914)
Browse files Browse the repository at this point in the history
### Related Ticket(s)

carbon-design-system#9567 

### Description

This updates the React masthead logo URL to use `https`.

### Changelog

**Changed**

- React masthead logo URL changed to use `https`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
  • Loading branch information
kennylam authored Jan 17, 2023
1 parent 91c71c8 commit 8a0e408
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 25 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ class BXDropdown extends ValidityMixin(
this.querySelectorAll(
(this.constructor as typeof BXDropdown).selectorItemSelected
),
item => {
(item) => {
(item as BXDropdownItem).selected = false;
}
);
Expand Down Expand Up @@ -312,7 +312,7 @@ class BXDropdown extends ValidityMixin(
this.querySelectorAll(
(this.constructor as typeof BXDropdown).selectorItemHighlighted
),
item => {
(item) => {
(item as BXDropdownItem).highlighted = false;
}
);
Expand All @@ -331,7 +331,7 @@ class BXDropdown extends ValidityMixin(
this.querySelectorAll(
(this.constructor as typeof BXDropdown).selectorItem
),
item => {
(item) => {
(item as BXDropdownItem).highlighted = false;
}
);
Expand Down Expand Up @@ -537,20 +537,20 @@ class BXDropdown extends ValidityMixin(
shouldUpdate(changedProperties) {
const { selectorItem } = this.constructor as typeof BXDropdown;
if (changedProperties.has('size')) {
forEach(this.querySelectorAll(selectorItem), elem => {
forEach(this.querySelectorAll(selectorItem), (elem) => {
(elem as BXDropdownItem).size = this.size;
});
}
if (changedProperties.has('value')) {
// `<bx-multi-select>` updates selection beforehand
// because our rendering logic for `<bx-multi-select>` looks for selected items via `qSA()`
forEach(this.querySelectorAll(selectorItem), elem => {
forEach(this.querySelectorAll(selectorItem), (elem) => {
(elem as BXDropdownItem).selected =
(elem as BXDropdownItem).value === this.value;
});
const item = find(
this.querySelectorAll(selectorItem),
elem => (elem as BXDropdownItem).value === this.value
(elem) => (elem as BXDropdownItem).value === this.value
);
if (item) {
const range = this.ownerDocument!.createRange();
Expand All @@ -570,7 +570,7 @@ class BXDropdown extends ValidityMixin(
if (changedProperties.has('disabled')) {
const { disabled } = this;
// Propagate `disabled` attribute to descendants until `:host-context()` gets supported in all major browsers
forEach(this.querySelectorAll(selectorItem), elem => {
forEach(this.querySelectorAll(selectorItem), (elem) => {
(elem as BXDropdownItem).disabled = disabled;
});
}
Expand Down Expand Up @@ -651,8 +651,7 @@ class BXDropdown extends ValidityMixin(
<div
part="helper-text"
class="${helperClasses}"
?hidden="${inline || !hasHelperText}"
>
?hidden="${inline || !hasHelperText}">
<slot name="helper-text" @slotchange="${handleSlotchangeHelperText}"
>${helperText}</slot
>
Expand All @@ -677,17 +676,15 @@ class BXDropdown extends ValidityMixin(
part="menu-body"
class="${prefix}--list-box__menu"
role="listbox"
tabindex="-1"
>
tabindex="-1">
<slot></slot>
</div>
`;
return html`
<label
part="label-text"
class="${labelClasses}"
?hidden="${!hasLabelText}"
>
?hidden="${!hasLabelText}">
<slot name="label-text" @slotchange="${handleSlotchangeLabelText}"
>${labelText}</slot
>
Expand All @@ -698,8 +695,7 @@ class BXDropdown extends ValidityMixin(
?data-invalid=${invalid}
@click=${handleClickInner}
@keydown=${handleKeydownInner}
@keypress=${handleKeypressInner}
>
@keypress=${handleKeypressInner}>
${validityIcon}
<div
part="trigger-button"
Expand All @@ -710,8 +706,7 @@ class BXDropdown extends ValidityMixin(
aria-expanded="${String(open)}"
aria-haspopup="listbox"
aria-owns="menu-body"
aria-controls="menu-body"
>
aria-controls="menu-body">
${this._renderPrecedingTriggerContent()}${this._renderTriggerContent()}${this._renderFollowingTriggerContent()}
<div class="${iconContainerClasses}">
${ChevronDown16({ 'aria-label': toggleLabel })}
Expand All @@ -724,8 +719,7 @@ class BXDropdown extends ValidityMixin(
class="${prefix}--assistive-text"
role="status"
aria-live="assertive"
aria-relevant="additions text"
>
aria-relevant="additions text">
${assistiveStatusText}
</div>
`;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,7 @@ class BXSelectableTile extends FocusMixin(LitElement) {
name="${ifNonNull(name)}"
value="${ifNonNull(value)}"
.checked=${selected}
@change=${handleChange}
/>
@change=${handleChange} />
<label for="input" class="${classes}" tabindex="0">
<div class="${prefix}--tile__checkmark">
${CheckmarkFilled16({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@ const { prefix } = settings;
* @element bx-tooltip
*/
@customElement(`${prefix}-tooltip`)
class BXTooltip extends HostListenerMixin(LitElement)
implements BXFloatingMenuTrigger {
class BXTooltip
extends HostListenerMixin(LitElement)
implements BXFloatingMenuTrigger
{
/**
* The menu body.
*/
Expand Down Expand Up @@ -67,7 +69,7 @@ class BXTooltip extends HostListenerMixin(LitElement)
*/
@HostListener('keydown')
// @ts-ignore: The decorator refers to this method but TS thinks this method is not referred to
private _handleKeydown = async event => {
private _handleKeydown = async (event) => {
if ([' ', 'Enter'].includes(event.key)) {
this._handleClick();
} else if (event.key === 'Escape') {
Expand Down Expand Up @@ -126,7 +128,7 @@ class BXTooltip extends HostListenerMixin(LitElement)
if (!this._menuBody) {
this._menuBody = find(
this.childNodes,
elem => (elem.constructor as typeof BXFloatingMenu).FLOATING_MENU
(elem) => (elem.constructor as typeof BXFloatingMenu).FLOATING_MENU
);
}
if (this._menuBody) {
Expand Down

0 comments on commit 8a0e408

Please sign in to comment.