Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'enforce-admins' for branch protection. #3

Open
wants to merge 1 commit into
base: protect-branch
Choose a base branch
from
Open

Add 'enforce-admins' for branch protection. #3

wants to merge 1 commit into from

Conversation

janjaapdriessen
Copy link

Add 'enforce-admins', without which Github API does not allow us to set branch protection.

@janjaapdriessen
Copy link
Author

I saw the kenshoo:protect-branch branch was mentioned in PyGithub#527 and checked it out, found that Github API requires the enforce_admins attribute. If you feel like it, please include this change in the PR. I thought of adding a test, but the run of ./manage.sh test3 already looks to fail on the enforce_admins parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant