Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add travis-ci.org build #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

talsalmona
Copy link
Contributor

Review on Reviewable

@liorhar
Copy link
Contributor

liorhar commented Mar 7, 2013

I see the build fails. Is there a way to export the test results so we can see which tests failed and their output?

@pepov
Copy link
Contributor

pepov commented Mar 7, 2013

Isn't it the case that fpm is not available?
https://api.travis-ci.org/jobs/5306387/log.txt?deansi=true

@talsalmona
Copy link
Contributor Author

Yes. I think so. Will take care of it (somehow)

On Thu, Mar 7, 2013 at 10:44 AM, Peter Wilcsinszky <notifications@github.com

wrote:

Isn't it the case that fpm is not available?
https://api.travis-ci.org/jobs/5306387/log.txt?deansi=true


Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-14548637
.

This e-mail, as well as any attached document, may contain material which
is confidential and privileged and may include trademark, copyright and
other intellectual property rights that are proprietary to Kenshoo Ltd,
its subsidiaries or affiliates ("Kenshoo"). This e-mail and its
attachments may be read, copied and used only by the addressee for the
purpose(s) for which it was disclosed herein. If you have received it in
error, please destroy the message and any attachment, and contact us
immediately. If you are not the intended recipient, be aware that any
review, reliance, disclosure, copying, distribution or use of the contents
of this message without Kenshoo's express permission is strictly prohibited.

@liorhar
Copy link
Contributor

liorhar commented Mar 7, 2013

btw, the fpm is just a ruby gem, can add this dependency on travis - http://about.travis-ci.org/docs/user/languages/ruby/

Tal Salmona added 2 commits March 7, 2013 11:09
This is a bit odd since I'm not sure in whic order travis-ci will interepert this since it's a Java project.
@talsalmona
Copy link
Contributor Author

Works well locally with bundler. Seems like travis-ci is ignoring the vendor packaged gem files in Java projects.
Need to find another way to do this.
Perhaps going back to my old idea of running this completely in JRuby thus removing any external dependencies is the way to go.

@liorhar
Copy link
Contributor

liorhar commented Mar 7, 2013

I don't think it worth the effort, need to make it a "pure" unit test so it's not depending on external dependencies.

@talsalmona
Copy link
Contributor Author

I think it is convenient to have travis-ci build it to get the test
feedback before merging pull requests and it would make the plugin more
portable.

On Thu, Mar 7, 2013 at 11:23 AM, liorhar notifications@github.com wrote:

I don't think it worth the effort, need to make it a "pure" unit test so
it's not depending on external dependencies.


Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-14550022
.

This e-mail, as well as any attached document, may contain material which
is confidential and privileged and may include trademark, copyright and
other intellectual property rights that are proprietary to Kenshoo Ltd,
its subsidiaries or affiliates ("Kenshoo"). This e-mail and its
attachments may be read, copied and used only by the addressee for the
purpose(s) for which it was disclosed herein. If you have received it in
error, please destroy the message and any attachment, and contact us
immediately. If you are not the intended recipient, be aware that any
review, reliance, disclosure, copying, distribution or use of the contents
of this message without Kenshoo's express permission is strictly prohibited.

@liorhar
Copy link
Contributor

liorhar commented Mar 7, 2013

of course, no argue we need a public build for this project, the question is how to test it, relying on external gem dependency or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants