Migrate the project to Micrometer backend #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR which changes the project to use Micrometer as it's Metrics backend.
We are proposing this change because it enables users to make use of dimensional metrics in those metrics systems that support it. This means that metrics can be tagged with extra metadata that allows metrics data to be broken down in many more different ways in the user's chosen metrics system.
We understand this is a huge change to the project but if you are happy to accept the change, we will write migration notes and any other documentation that is required in order to understand how to migrate code to the new version of the project.
The largest change is to the metrics Json endpoint and to the metric names that are exposed by default. This is due to differences in the metrics name that are used in the JVM and logback metric sets that are provided by Micrometer. Micrometer also does not support rate aggregation for timers as its common for users to do this in their metrics database system now.
It's possible to continue using Dropwizard as the reporting backend for metrics as Micrometer supports a Dropwizard meter registry.
Contributed by @DavidGregory084 and myself on behalf of the @opencastsoftware open source team. 👋