Issue #149 - It is possible to select more than maxSelectedItems when…

… using Shift
kenshoo · Jul 10, 2019 · 9a4c39f · 9a4c39f
1 parent e763c1a
commit 9a4c39f
Show file tree

Hide file tree

Showing 4 changed files with 153 additions and 5 deletions.
diff --git a/src/components/multi_select_state.js b/src/components/multi_select_state.js
@@ -1,6 +1,8 @@
 import React, { PureComponent } from "react";
 import {
   getSelectedByAllItems,
+  getSelectedItemsOutsideInterval,
+  getAvailableIntervalForSelection,
   filterUnselectedByIds,
   findItem,
   getMinMaxIndexes,
@@ -66,16 +68,32 @@ const withMultiSelectState = WrappedComponent =>
     }
 
     handleMultiSelection(index) {
-      const { items, isLocked } = this.props;
-      const { filteredItems, firstItemShiftSelected } = this.state;
+      const { items, isLocked, maxSelectedItems } = this.props;
+      const {
+        filteredItems,
+        firstItemShiftSelected,
+        selectedItems
+      } = this.state;
+
+      const initialInterval = getMinMaxIndexes(index, firstItemShiftSelected);
+      const outsideIntervalSelectedItems = getSelectedItemsOutsideInterval(
+        items,
+        selectedItems,
+        initialInterval
+      );
+      const interval = getAvailableIntervalForSelection(
+        initialInterval,
+        outsideIntervalSelectedItems.length,
+        maxSelectedItems,
+        firstItemShiftSelected
+      );
 
-      const interval = getMinMaxIndexes(index, firstItemShiftSelected);
       const newSelectedItems = items.filter(
         (item, index) =>
           (isWithin(index, interval) &&
             !isLocked(item) &&
             findItem(item, filteredItems)) ||
-          findItem(item, this.state.selectedItems)
+          findItem(item, outsideIntervalSelectedItems)
       );
       const newFilteredSelectedItems = this.getNewFilteredSelectedItems(
         newSelectedItems

diff --git a/src/components/multi_select_state_utils.js b/src/components/multi_select_state_utils.js
@@ -37,6 +37,50 @@ export const getMinMaxIndexes = (currentIndex, firstItemShiftSelected) =>
     ? { minIndex: currentIndex, maxIndex: firstItemShiftSelected }
     : { minIndex: firstItemShiftSelected, maxIndex: currentIndex };
 
+export const getAvailableIntervalForSelection = (
+  interval,
+  outsideSelectedItems,
+  maxSelectedItems,
+  firstItemShiftSelected
+) => {
+  const { minIndex, maxIndex } = interval;
+  const shouldBeSelect = outsideSelectedItems + (maxIndex - minIndex);
+  return maxSelectedItems > 0 && maxSelectedItems <= shouldBeSelect
+    ? getFixedInterval(
+        interval,
+        outsideSelectedItems,
+        maxSelectedItems,
+        firstItemShiftSelected
+      )
+    : interval;
+};
+
+const getFixedInterval = (
+  { minIndex, maxIndex },
+  outsideSelectedItems,
+  maxSelectedItems,
+  firstItemShiftSelected
+) => ({
+  minIndex:
+    maxIndex === firstItemShiftSelected
+      ? maxIndex - (maxSelectedItems - outsideSelectedItems - 1)
+      : minIndex,
+  maxIndex:
+    minIndex === firstItemShiftSelected
+      ? minIndex + (maxSelectedItems - outsideSelectedItems - 1)
+      : maxIndex
+});
+
+export const getSelectedItemsOutsideInterval = (
+  sourceItems,
+  selectedItems,
+  interval
+) =>
+  selectedItems.filter(selectedItem => {
+    const index = sourceItems.findIndex(item => item.id === selectedItem.id);
+    return !isWithin(index, interval) || selectedItem.disabled;
+  });
+
 export const isWithin = (index, { minIndex, maxIndex }) =>
   index >= minIndex && index <= maxIndex;
 

diff --git a/tests/components/multi_select_state.spec.js b/tests/components/multi_select_state.spec.js
@@ -715,4 +715,40 @@ describe("withMultiSelectState", () => {
       items[4]
     ]);
   });
+
+  test("case select with shift items where shouldBeSelect > maxSelectedItems", () => {
+    const ConditionalComponent = withMultiSelectState(CustomComponent);
+    const items = [ITEM_1, ITEM_2, ITEM_3, ITEM_4, ITEM_12];
+
+    const wrapper = shallow(
+      <ConditionalComponent
+        items={items}
+        selectedItems={[ITEM_1]}
+        maxSelectedItems={3}
+      />
+    );
+    wrapper.props().selectItem(EVENT_WITH_SHIFT, ITEM_12.id);
+    wrapper.update();
+    wrapper.props().selectItem(EVENT_WITH_SHIFT, ITEM_3.id);
+    wrapper.update();
+    expect(wrapper.prop("selectedItems")).toEqual([ITEM_1, ITEM_4, ITEM_12]);
+  });
+
+  test("case select with shift items where shouldBeSelect < maxSelectedItems", () => {
+    const ConditionalComponent = withMultiSelectState(CustomComponent);
+    const items = [ITEM_1, ITEM_2, ITEM_3, ITEM_4];
+
+    const wrapper = shallow(
+      <ConditionalComponent
+        items={items}
+        selectedItems={[]}
+        maxSelectedItems={4}
+      />
+    );
+    wrapper.props().selectItem(EVENT_WITH_SHIFT, ITEM_1.id);
+    wrapper.update();
+    wrapper.props().selectItem(EVENT_WITH_SHIFT, ITEM_3.id);
+    wrapper.update();
+    expect(wrapper.prop("selectedItems")).toEqual([ITEM_1, ITEM_2, ITEM_3]);
+  });
 });
diff --git a/tests/components/multi_select_state_utils.spec.js b/tests/components/multi_select_state_utils.spec.js
@@ -1,6 +1,8 @@
 import {
   filterUnselectedByIds,
-  getSelectedByAllItems
+  getSelectedByAllItems,
+  getSelectedItemsOutsideInterval,
+  getAvailableIntervalForSelection
 } from "../../src/components/multi_select_state_utils";
 
 const items = [
@@ -76,4 +78,52 @@ describe("testing utils for multi select state", () => {
     );
     expect(allSelectedItems).toEqual([]);
   });
+
+  test("filter selectedItems that not in interval", () => {
+    const selectedItemsOutsideInterval = getSelectedItemsOutsideInterval(
+      items,
+      selectedItems,
+      { minIndex: 1, maxIndex: 3 }
+    );
+    expect(selectedItemsOutsideInterval.length).toEqual(1);
+    expect(selectedItemsOutsideInterval[0]).toEqual(selectedItems[0]);
+  });
+
+  test("filter itemsToSelect that not in interval", () => {
+    const selectedItemsOutsideInterval = getSelectedItemsOutsideInterval(
+      items,
+      itemsToSelect,
+      { minIndex: 0, maxIndex: 3 }
+    );
+    expect(selectedItemsOutsideInterval.length).toEqual(0);
+  });
+
+  test("available interval when minIndex == firstItemShiftSelected", () => {
+    const initialInterval = { minIndex: 0, maxIndex: 3 };
+    const maxSelectedItems = 3;
+    const selectedItemsOutsideInterval = 0;
+    const firstItemShiftSelected = 0;
+    const availableInterval = getAvailableIntervalForSelection(
+      initialInterval,
+      selectedItemsOutsideInterval,
+      maxSelectedItems,
+      firstItemShiftSelected
+    );
+    expect(availableInterval).toEqual({ minIndex: 0, maxIndex: 2 });
+  });
+
+  test("available interval when maxIndex == firstItemShiftSelected", () => {
+    const initialInterval = { minIndex: 1, maxIndex: 3 };
+    const maxSelectedItems = 3;
+    const selectedItemsOutsideInterval = 1;
+    const firstItemShiftSelected = 3;
+
+    const availableInterval = getAvailableIntervalForSelection(
+      initialInterval,
+      selectedItemsOutsideInterval,
+      maxSelectedItems,
+      firstItemShiftSelected
+    );
+    expect(availableInterval).toEqual({ minIndex: 2, maxIndex: 3 });
+  });
 });