Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a will receive props method to filter items on every search value change #108

Merged
merged 4 commits into from
Oct 24, 2018
Merged

Added a will receive props method to filter items on every search value change #108

merged 4 commits into from
Oct 24, 2018

Conversation

eran7789
Copy link
Contributor

@eran7789 eran7789 commented Oct 17, 2018 •
edited
Loading

Fixes #
#104

Proposed Changes

  • Added a componentWillReceivePropsLifecycle method to handle the value changing from outside the component and filter items in response.

@talyak talyak self-requested a review October 21, 2018 04:03
@talyak talyak requested a review from liorheber October 21, 2018 04:07
@eran7789
Copy link
Contributor Author

@liorheber can you please review?

@AmirAsaraf AmirAsaraf merged commit 0e4f4cf into kenshoo:master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmirAsaraf AmirAsaraf AmirAsaraf approved these changes

@talyak talyak talyak approved these changes

@liorheber liorheber Awaiting requested review from liorheber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eran7789 @AmirAsaraf @talyak