Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export default components #117

Closed
wants to merge 1 commit into from
Closed

export default components #117

wants to merge 1 commit into from

Conversation

sabativi
Copy link

Proposed Changes

  • export default components so that we can compose behaviours based on them

Notes

I have huge difficulties running this locally, I tried to install an npm package to show reorder of elems but it crash, I thought it was a node version problem but apparently not.

I have tried to install the package locally from another project but I have a "window is undefined".

So I propose to merge this PR, build the package so that I can install it and make an example with sortable-js.

@liorheber
Copy link
Collaborator

Thanks for looking into this feature!

@sabativi it sounds a bit critical that you're having issues using the component.
Could I ask that you share a bit more information on the issue you're receiving?
The stack trace of the error? How you used the component when it failed etc.?

As for this PR, if you need the default component to get this feature to work, doesn't it mean that it will break for someone who's using their own renderer for the component?
Seems to me that the solution needs to be a bit more generic.

@sabativi
Copy link
Author

The 'window' is not defined problem was a mistake from I.

I will try to integrate with https://github.com/clauderic/react-sortable-hoc as it says that it works with react-virtualized which is used by this module.

Will keep you updated

@liorheber
Copy link
Collaborator

Great news, thanks!

@talyak
Copy link
Collaborator

talyak commented Dec 18, 2018

@sabativi - Can I close this PR?

@sabativi
Copy link
Author

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants