Update README file #147
Update README file #147
Conversation
| @@ -25,6 +25,7 @@ const Tree = props => { | |||
| onSelect, | |||
| width, | |||
| height, | |||
| styles, | |||
There was a problem hiding this comment.
@liorheber In the previous PRs I removed "styles" and "classname" props bacuse I thought They are not in use.
Noe when writing the README I understood the "styles" is needed for customized styles.
What about calssname? Do we need this property?
There was a problem hiding this comment.
Which classNames? Can you link the change?
You would usually need the className prop to customize using almost any styling library - css modules, styled-components etc.
There was a problem hiding this comment.
https://github.com/kenshoo/react-tree/pull/143/files
@liorheber I tagged you in the PR
There was a problem hiding this comment.
They are for customization, however, I'm not sure it was fully implemented.
I suggest returning it and we can have a look at it at a later task when we decide to support that type of customization.
| npm install @kenshooui/material-tree --save | ||
|
|
||
| npm install @kenshooui/react-tree --save | ||
|
|
||
| npm install @material-ui/core --save | ||
|
|
||
| npm install @material-ui/icons --save |
There was a problem hiding this comment.
You can do this, and the yarn command in a single line -
npm install --save @material-ui/core @material-ui/icons @kenshooui/react-tree @kenshooui/material-tree
yarn add @material-ui/core @material-ui/icons @kenshooui/react-tree @kenshooui/material-tree
Also worth mentioning that the material dependencies are only if they don't exist already in the app.
There was a problem hiding this comment.
@liorheber isn't this enough: "In addition, dependencies to material-ui icons and core components are needed if they don't exist in your project." ?
Do you want me to rephrase it?
|
Merging this, please fix my comments in another PR. |
|
You also need to place the API documentation of the core component in the core package. |
@liorheber This PR included few changes in the components as well. Do we want to avoid releasing in this case? |
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @kenshooui/react-tree@0.0.19-canary.147.400.0 npm install @kenshooui/material-tree@0.0.2-canary.147.400.0 # or yarn add @kenshooui/react-tree@0.0.19-canary.147.400.0 yarn add @kenshooui/material-tree@0.0.2-canary.147.400.0