Add customItemsRenderer prop #152
Conversation
packages/core/src/tree.js
Outdated
| </Items> | ||
| {customItemsRenderer ? ( | ||
| React.cloneElement(customItemsRenderer, { | ||
| ...props, |
There was a problem hiding this comment.
I'm not sure we should just pass the props (I'm talking about ...props), the props are meant for tree.
As any custom renderer, you can OTHER props externally when you do something like
<Tree customItemsRenderer=<MyRenderer someProp={} />
Unless you mean yo pass something like
<Tree customItemsRenderer={someRenderer}/>
In which case you also need to create the component in the tree and you can still pass props using something like
<Tree customItemsRenderer={() => <SomeRenderer .../>}/>
Hope my comment is understandable.
| forwardIconRenderer={forwardIconRenderer} | ||
| selectedItem={selectedItem} |
There was a problem hiding this comment.
You don't want to pass these two?
There was a problem hiding this comment.
as I see selected Item we pass externally
There was a problem hiding this comment.
ForwardIconRenderer the same
There was a problem hiding this comment.
I think it's important we maintain the same API.
IT would be very confusing if the icons work in one instance but if you pass a custom list they don't.
There was a problem hiding this comment.
Just a ping on this so that we can merge
|
Don't forget to update the readmes |
|
Is it manually change? or we have specific tool for readme generation? |
|
Unfortunately manual at this point. |
We extends from BaseList in hierarchical_select
It's different way to drilling props
In the react-tree it's native div tag.
That's why was added customItemsRenderer
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @kenshooui/react-tree@0.0.20-canary.152.423.0 npm install @kenshooui/material-tree@0.0.3-canary.152.423.0 # or yarn add @kenshooui/react-tree@0.0.20-canary.152.423.0 yarn add @kenshooui/material-tree@0.0.3-canary.152.423.0