Basics #60
Merged
Basics #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kenshoo/uiinfra please have a look on this PR - implemented it inspired by react-select |
orineuman
commented
Mar 23, 2020
liorheber
reviewed
Mar 23, 2020
liorheber
reviewed
Mar 23, 2020
liorheber
reviewed
Mar 23, 2020
liorheber
reviewed
Mar 23, 2020
liorheber
reviewed
Mar 23, 2020
liorheber
reviewed
Mar 23, 2020
liorheber
reviewed
Mar 23, 2020
liorheber
reviewed
Mar 23, 2020
liorheber
reviewed
Mar 23, 2020
liorheber
reviewed
Mar 23, 2020
liorheber
reviewed
Mar 23, 2020
| @@ -4558,7 +4570,7 @@ class-utils@^0.3.5: | |||
| isobject "^3.0.0" | |||
| static-extend "^0.1.1" | |||
|
|
|||
| classnames@^2.2.5: | |||
| classnames@^2.2.5, classnames@^2.2.6: | |||
There was a problem hiding this comment.
mind checking why we have two classnames dependencies in the project?
There was a problem hiding this comment.
how do you check such a thing?
There was a problem hiding this comment.
yarn.lock
It will show you who depends on what.
There was a problem hiding this comment.
yes I know this is what we see here but I added "classnames": "^2.2.6" - why it keeps the 2.2.5?
There was a problem hiding this comment.
You didn't look :)
If you look at yarn.lock you will see that react-draggable is using it which is used by storybook.
We're good.
liorheber
reviewed
Mar 31, 2020
| css={getStyles("input", props)} | ||
| value={searchTerm} | ||
| onChange={e => setSearchTerm(e.target.value)} | ||
| /> |
There was a problem hiding this comment.
Wasn't there a clear input here at some point?
liatgo
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic layout
css in js with customization via props
renderers via props
Next: more tests, classnames
@kenshoo/uiinfra @yarin-kenshoo
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @kenshooui/react-tree@0.0.18-canary.60.213.0 # or yarn add @kenshooui/react-tree@0.0.18-canary.60.213.0