This repository has been archived by the owner on Jan 6, 2021. It is now read-only.
fix(module): Add export for commonjs #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add commonjs export, so it is possible to require crossEnv using `require('cross-env')` (needed to
use in js script without babel)
84
kentcdodds
suggested changes
Mar 14, 2017
src/index.test.js
Outdated
| @@ -1,10 +1,17 @@ | |||
| import crossSpawnMock from 'cross-spawn' | |||
| import crossEnv from '.' | |||
|
|
|||
| const commonJSCrossEnv = require('.') | |||
src/index.js
Outdated
| @@ -1,6 +1,7 @@ | |||
| import {spawn} from 'cross-spawn' | |||
| import commandConvert from './command' | |||
|
|
|||
| module.exports = crossEnv | |||
| export default crossEnv | |||
There was a problem hiding this comment.
Go ahead and remove this and just disable the rule for the offending line
There was a problem hiding this comment.
Yes sure, I do it now
There was a problem hiding this comment.
Do you prefer a new commit or a push -f ?
There was a problem hiding this comment.
Either way is fine, I'll do a squash and merge when I merge your pull request anyway
|
Thanks! |
kentcdodds
pushed a commit
that referenced
this pull request
Mar 31, 2017
* fix(module): Add export for commonjs
Add commonjs export, so it is possible to require crossEnv using `require('cross-env')` (needed to
use in js script without babel)
84
* fix(module): Only export crossEnv using commonjs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add commonjs export, so it is possible to require crossEnv using
require('cross-env')(needed touse in js script without babel)
#84