-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests to verify error messages thrown by commands #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Thank you!
Cypress uses chai for assertion causing the lint to fail
Also, the test |
I just confirmed that it works on |
Let's keep this open until dom-testing-library had been updated and published here |
Yeah, that's what I was thinking. When dom-testing-library is published I'll update the dependency in this PR and add contributor as well :) |
Should be ready |
@kentcdodds Dependency is updated 👍 I think the CI will still fail on one test due to the issue with cypress |
@kentcdodds @misoguy One of your dom utilities is yielding an array of native dom elements, and cypress commands expect jquery element arrays. Cypress previously wrapped the array in jquery but this was undefined behavior, thus it was not captured in a spec and changed unknowingly in 3.1.2. We've decided to add that functionality to the spec and will have this fix out in a patch release. so your tests will pass after the next patch release |
@bkucera Thank you! |
@kentcdodds Could we have this merged and released? The issue on cypress seems to be taking a bit more time than anticipated and my tests are spitting too much dom nodes on failing tests. 😞 We could fix the |
It can't be released until CI is passing (releases are automated). |
CI will pass if we change the version of |
Let's go ahead and lock the version for now |
I locked the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
My pleasure 😄 |
🎉 This PR is included in version 2.3.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This PR adds tests to verify this issue I added in https://github.com/kentcdodds/dom-testing-library
This PR is intended to fail.
When the issue at dom-testing-library resolves and the dependency is updated with a new release, this test should pass.