Remove dom node in error messages in cypress environment #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misoguy
changed the title
kentcdodds
reviewed
Nov 21, 2018
|
Also, thanks! |
|
@kentcdodds added the |
|
🎉 This PR is included in version 3.12.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #156 and also resolves testing-library/cypress-testing-library#25
What: This PR removes the dom nodes being printed from the error message shown in cypress when a test fails to locate the specified dom node.
Why: Showing the whole dom in cypress clutters up the error log.
How: There was already a condition present to prevent printing out dom node in cypress but it is not valid in latest version of cypress which is why I added another condition to make this work.
Checklist: