getByDisplayValue is missing in TypeScript types

[theforce1989]

• cypress-testing-library version: 3.0.1
• node version: 11.10.0
• yarn version: 1.14.0

Relevant code or config

cy.getByDisplayValue("something");

What you did:
updated to cypress-testing-library 3.0.1 and because of breaking changes in dom-testing-library as outlined in the release notes, I switched my getByValue queries to getByDisplayValue.

What happened:
TS compile fails because getByDisplayValue is not defined in cypress-testing-library/typings

Suggested solution:
update typings to reflect the changes in the API

[kentcdodds]

Thanks for the issue. Could you make a pull request to add them?

[ppi-buck]

The PR should also include updated tests inside https://github.com/testing-library/cypress-testing-library/blob/master/cypress/integration/commands.spec.js and https://github.com/testing-library/cypress-testing-library/blob/master/tests/typescript-types/test.spec.ts if possible.

Because these tests are missing the *ByValue or *ByDisplayValue all together the issue didn't occur automatically earlier.

PS: For now the PR only contains the fixes but I might get back to adjusting the tests and creating another PR for those. Not enough time right now

[kentcdodds]

🎉 This issue has been resolved in version 4.0.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀